Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure RV and SDE calculations are not impacted by randomazation #1888

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Make sure RV and SDE calculations are not impacted by randomazation #1888

merged 1 commit into from
Jul 30, 2024

Conversation

dczulada
Copy link
Contributor

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@dczulada dczulada requested a review from luis1van July 30, 2024 14:46
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (4046f3d) to head (42ea463).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
+ Coverage   96.13%   96.36%   +0.22%     
==========================================
  Files         157      157              
  Lines        7087     7091       +4     
==========================================
+ Hits         6813     6833      +20     
+ Misses        274      258      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dczulada dczulada merged commit 8b0302b into master Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis1van luis1van luis1van approved these changes

Assignees

@luis1van luis1van

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dczulada @luis1van